-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows GUI: Prevent repeated execution of certain code #853
Conversation
Ensure code that is only necessary to execute once on application start-up is not repeated every time FormShow is called such as when switching dark mode.
Okay, dark mode switching should work well now and without resetting to basic view. |
Removed commented-out testing code that I accidentally left there. |
Oh no, HTML view is a little buggy now. Maybe need to put a refresh somewhere. |
I can't figure out what is going on with HTML view now. It's a minor issue where HTML has to be clicked 2 times after switching dark mode else it is blank. |
I can reproduce this issue but I'll survive with it for the moment :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not perfect but a lot better than before so I merge that.
An unrelated issue I found while testing is that if debug mode is toggled, the text view will be blank no matter what is toggled until application restart. I am not sure how debug mode is supposed to be used though. |
General information: the code is very old (really... ~20 years) and messy, lot of unnecessary UI updates, we don't have much time on our side for it but if you are motivated we would be happy that you make it simpler. Thank you again for your work. |
Drag and drop again a file :). |
Glad to help.
Don't think I will do anything about that since I don't need that and no idea how to do. 😄 Noticed the contents of View -> Your system doesn't seem to correlate with the 3 radio button selections too but I don't use this page also. |
Ensure code that is only necessary to execute once on application start-up is not repeated every time FormShow is called such as when switching dark mode.
Resolves bugs mentioned in #836 (comment)
Also makes dark mode switching faster.
PR #851 and #852 no longer needed. Now the view will not change when switching dark mode.