Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows GUI: Use older API for getting system DPI, update #860

Merged
merged 1 commit into from
May 31, 2024

Conversation

JeromeMartinez
Copy link
Member

No description provided.

@JeromeMartinez JeromeMartinez merged commit 80dc38b into MediaArea:master May 31, 2024
2 of 3 checks passed
@JeromeMartinez
Copy link
Member Author

For an unknown reason the binary is trying to load the function even if the function is not called, this was not expected, usually the crash happens only when the function is called, so we remove it completely as an hotfix for the release.

@cjee21
Copy link
Collaborator

cjee21 commented Jun 1, 2024

For an unknown reason the binary is trying to load the function even if the function is not called, this was not expected

Looks like it is looking for GetSystemDpiForProcess immediately on start before application code is run. Seems need to use LoadLibrary and GetProcAddress if we still want to use newer API on newer Windows.

@cjee21
Copy link
Collaborator

cjee21 commented Jun 1, 2024

@JeromeMartinez please take a look at #861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants