-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows GUI: Implement theme preferences #871
Conversation
@cjee21 thank you for your help there, very appreciated. |
(and I know that this 20 year old code is super messy, it needs a bug clean up :( ) |
While looking around I came across this if (Page->ActivePage==Page_Sheet) //TODO : find WHY there is a crash without this...
ChangePage(Page_Easy);
delete Prefs; Prefs=NULL;
delete I; I=NULL; Found that the crash is due to this line: delete Prefs; Prefs=NULL; After debugging, found that after |
After moving stuff around, it appears to be working as expected now but probably need more testing to make sure nothing gets accidentally broken. |
@cjee21 please rebase then I do so tests on the GUI. |
Enable user to save their preferences for application theme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could also be in the main page of the preference window (below "output format") in another PR, if you are motivated.
Thank you again, your help is greatly appreciated!
Enable user to save their preferences for application theme.
This is an implementation of the suggestion in #836 (comment) which I am only able to implement now after studying and figuring out how MediaInfo handle preferences.
Fixed in latest force push: