-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MP4: improve display of operating system and hardware #2189
base: master
Are you sure you want to change the base?
MP4: improve display of operating system and hardware #2189
Conversation
Focused on Android and iOS but also handle some cameras
Here is the output with MediaInfo built from this branch on a video from S23 Ultra that someone sent to me:
Performer is still there... and hardware missing 'Galaxy S23 Ultra'... not expected right? For another model looks fine:
|
I created a file based on what I understood as being there, looks like it is not the exact way in the file :(. |
Argh, I see, I wrongly wrote "Samsung" instead of "Galaxy" in the file, I change my file and tweak the code. |
The thing is, some Samsung phones contain Samsung there and some Galaxy... |
I will manage both. |
What is the exact string of a file having "Samsung"? |
MediaTrace of file from Galaxy S23: #2179 (comment) I only have files from two types of Samsung phones so don't know if there are other possibilities. Both phones not mine. So far I have not seen other brand Android phones that write this kind of info. Others only have |
So no "S23" with "Samsung", always with "Galaxy".
Even my A41 does not have any info... but still good to show when it is present, and we'll see if we find more... |
I mean, "Samsung" seems used for the model (technical) name, "Galaxy" for the marketing name, at least up to now. |
This PR causes performers such as "Samsung Electronics Nano Philharmonic Orchestra" to not be displayed correctly. |
Argh! I need to find a more proper way... Maybe with testing only "Galaxy" there, not "Samsung". |
I just tried tagging the previous sample file with Mp3tag. That orchestra name I found on Google. If the Samsung metadata is removed first then it shows performer correctly. Take note that someone might be named Galaxy too 😉 |
Sample after tagging with Mp3tag: |
At some point I need to have a rule... :( |
For some reason, the performer saved by the phone does not show in Mp3tag or FFmpeg. Only the one added by Mp3tag shows. So there is a difference? |
This file has 2 "Performer" fields, one old fashion "auth" atom and another "©ART" in "meta" atom, but I see the idea. |
Improvement of #2179.
Focused on Android and iOS but also handle some cameras, and XML or JSON outputs have separate fields for company name, product name, model, similar to writing app and library.
e.g.
cc @cjee21.