fix: refactor docs-ci downstream trigger to operate via workflow_dispatch only #1258
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atch only upstrema will also print downstream url and propagate its result. Signed-off-by: Michael Zeevi <[email protected]>
Pull Request Test Coverage Report for Build 12853791790Details
💛 - Coveralls |
rollandf
reviewed
Jan 21, 2025
| runs-on: ubuntu-latest | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GH_TOKEN_NVIDIA_CI_CD }} | ||
| GIT_TAG: ${{ github.ref_name }} |
There was a problem hiding this comment.
Note that in doc CI we also need:
env:
NGC_CLI_API_KEY: ${{ secrets.NVCR_TOKEN }}
https://github.com/Mellanox/network-operator-docs/blob/main/.github/workflows/docs-ci.yaml#L35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change is coupled with the change in network-operator: Mellanox/network-operator-docs#166
The workflow also prints the URL to the downstream workflow, and its result is propagated (upstream will fail if downstream fails).