feat: add podAntiAffinity to MOFED #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rollandf
commented
Dec 18, 2023
rollandf
commented
- Add podAntiAffinity to MOFED
- Add unit test to check PodAntiAffinity rendering
- Add unit test to check NodeSelector rendering
- Extract methods in state_ofed for better readability
rollandf
requested review from
adrianchiris,
e0ne,
ykulazhenkov and
almaslennikov
vasrem
approved these changes
Dec 18, 2023
pkg/state/state_ofed_test.go
Outdated
| ds := appsv1.DaemonSet{} | ||
| err = runtime.DefaultUnstructuredConverter.FromUnstructured(obj.Object, &ds) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(ds.Name).To(BeEquivalentTo(fmt.Sprintf("mofed-%s%s-ds", osName, osVer))) |
There was a problem hiding this comment.
nit: I think it's more clear to hardcode the expected value instead of building it up for readability (just in tests).
Also, BeEquivalentTo() could be replaced with Equal() as ds.Name is just a string.
rollandf
force-pushed
the
ofed-state-test
branch
from
bdb08d1 to
e645885
Compare
- Add podAntiAffinity to MOFED - Add unit test to check PodAntiAffinity rendering - Add unit test to check NodeSelector rendering - Extract methods in state_ofed for better readability Signed-off-by: Fred Rolland <[email protected]>
rollandf
force-pushed
the
ofed-state-test
branch
from
e645885 to
31f75e1
Compare
ykulazhenkov
approved these changes
Dec 19, 2023
rollandf
added a commit
to rollandf/network-operator
that referenced
this pull request
Mar 6, 2024
- Add additional mounts to DTK container - Fix additional mounts handling issue introduced in Mellanox#707 Signed-off-by: Fred Rolland <[email protected]>
rollandf
added a commit
to rollandf/network-operator
that referenced
this pull request
Mar 6, 2024
- Add additional mounts to DTK container - Fix additional mounts handling issue introduced in Mellanox#707 Signed-off-by: Fred Rolland <[email protected]>
e0ne
added a commit
that referenced
this pull request
Mar 6, 2024
- Add additional mounts to DTK container - Fix additional mounts handling issue introduced in #707
rollandf
added a commit
to rollandf/network-operator
that referenced
this pull request
Mar 7, 2024
- Add additional mounts to DTK container - Fix additional mounts handling issue introduced in Mellanox#707 Signed-off-by: Fred Rolland <[email protected]> (cherry picked from commit 63502df)
rollandf
added a commit
to rollandf/network-operator
that referenced
this pull request
Mar 7, 2024
- Add additional mounts to DTK container - Fix additional mounts handling issue introduced in Mellanox#707 Signed-off-by: Fred Rolland <[email protected]> (cherry picked from commit 63502df)
e0ne
added a commit
that referenced
this pull request
Mar 7, 2024
- Add additional mounts to DTK container - Fix additional mounts handling issue introduced in #707 Signed-off-by: Fred Rolland <[email protected]> (cherry picked from commit 63502df)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.