chore: Disable default golangci-lint exclusions #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killianmuldoon
commented
Dec 19, 2023
| @@ -21,6 +21,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| // HostDeviceNetworkCRDName is used for the CRD Kind. | |||
There was a problem hiding this comment.
Most of the changes in this PR are adding comments or slightly changing existing comments to meet Go conventions.
There was a problem hiding this comment.
Enabling this now and fixing outstanding issues means we'll have a check for comments on packages and exported types in future.
| @@ -133,7 +135,7 @@ func main() { | |||
| } | |||
| // Generate new file full path | |||
| outputFile := filepath.Join(*outputDir, strings.Replace(filepath.Base(file), ".template", ".yaml", 1)) | |||
| f, err := os.Create(outputFile) | |||
| f, err := os.Create(filepath.Clean(outputFile)) | |||
There was a problem hiding this comment.
There's three instances of adding filepath.Clean() to file operations which was caught by the gosec linter.
killianmuldoon
changed the title
killianmuldoon
force-pushed
the
pr-lint-defaults
branch
from
7f6ca0e to
9b0662c
Compare
|
Hey, add a new line to the PR text to make |
|
Should we hold this to not get conflict with Alex's PRs? |
|
Hey, after merging #706 the project layout has changed. Could you rebase your PR? |
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
pr-lint-defaults
branch
from
9b0662c to
b6d1bd7
Compare
rollandf
approved these changes
Dec 20, 2023
e0ne
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
.issues.exclude-use-default: falseto expose new linter findings and fix them.This will enable checking for package comments and comments on exported types going forward.