use default browser, fix crash for matrix links, fix crash for search… (

#481)

src/components/screens/Feed/CommunityFeedScreen.tsx

@@ -34,7 +34,7 @@ function FeedsCommunityScreen({
       <Text fontSize={16} fontWeight="semibold">
         {communityName.toString()}
       </Text>
-      <Text fontSize={12}>@{getBaseUrl(actorId.toString())}</Text>
+      <Text fontSize={12}>@{getBaseUrl(actorId?.toString())}</Text>
     </VStack>
   );
 

src/components/screens/Settings/General/GeneralSettingsScreen.tsx

@@ -2,7 +2,7 @@ import { useActionSheet } from "@expo/react-native-action-sheet";
 import { TableView } from "@gkasdorf/react-native-tableview-simple";
 import { ScrollView, useTheme } from "native-base";
 import React from "react";
-import { StyleSheet } from "react-native";
+import { StyleSheet, Switch } from "react-native";
 import { setSetting } from "../../../../slices/settings/settingsActions";
 import { selectSettings } from "../../../../slices/settings/settingsSlice";
 import { useAppDispatch, useAppSelector } from "../../../../../store";
@@ -17,6 +17,10 @@ function GeneralSettingsScreen() {
   const theme = useTheme();
   const { showActionSheetWithOptions } = useActionSheet();
 
+  const onChange = (key: string, value: any) => {
+    dispatch(setSetting({ [key]: value }));
+  };
+
   return (
     <ScrollView backgroundColor={theme.colors.app.bg} flex={1}>
       <TableView style={styles.table}>
@@ -48,6 +52,20 @@ function GeneralSettingsScreen() {
             }}
           />
         </CSection>
+        <CSection header="BROWSER">
+          <CCell
+            title="Use Default Browser"
+            backgroundColor={theme.colors.app.fg}
+            titleTextColor={theme.colors.app.textPrimary}
+            rightDetailColor={theme.colors.app.textSecondary}
+            cellAccessoryView={
+              <Switch
+                value={settings.useDefaultBrowser}
+                onValueChange={(v) => onChange("useDefaultBrowser", v)}
+              />
+            }
+          />
+        </CSection>
       </TableView>
     </ScrollView>
   );

src/helpers/LinkHelper.ts

@@ -1,7 +1,7 @@
 import * as WebBrowser from "expo-web-browser";
 import { WebBrowserPresentationStyle } from "expo-web-browser";
 import { NativeStackNavigationProp } from "@react-navigation/native-stack";
-import { Alert } from "react-native";
+import { Alert, Linking } from "react-native";
 
 import axios from "axios";
 import { URL } from "react-native-url-polyfill";
@@ -157,17 +157,27 @@ const openLemmyLink = (
 };
 
 const openWebLink = (link: string): void => {
+  const { settings } = store.getState();
   const urlPattern =
     /(http|https):\/\/([\w_-]+(?:(?:\.[\w_-]+)+))([\w.,@?^=%&:/~+#-]*[\w@?^=%&/~+#-])/;
 
-  const { settings } = store.getState();
   try {
     writeToLog(`Trying to open link: ${link}`);
 
     let fixedLink = decodeURIComponent(link);
     fixedLink = fixedLink.match(urlPattern)[0];
     fixedLink = fixedLink.replace("%5D", "");
 
+    // TODO Remove this once Expo publishes new fix. For now this will stop matrix crashes
+
+    const matrixCheck = /#/g;
+    const matrixCheckCount = (link.match(matrixCheck) || []).length;
+
+    if (settings.useDefaultBrowser || matrixCheckCount > 1) {
+      Linking.openURL(link).then();
+      return;
+    }
+
     WebBrowser.openBrowserAsync(fixedLink, {
       dismissButtonStyle: "close",
       readerMode: settings.useReaderMode,

src/slices/settings/settingsSlice.ts

@@ -38,6 +38,7 @@ export interface SettingsState {
   hideReadPostsOnFeed: boolean;
   appIcon: string;
   showCommentActions: boolean;
+  useDefaultBrowser: boolean;
 }
 
 const initialState: SettingsState = {
@@ -72,6 +73,7 @@ const initialState: SettingsState = {
   hideReadPostsOnFeed: false,
   appIcon: "purple",
   showCommentActions: true,
+  useDefaultBrowser: false,
 };
 
 const settingsSlice = createSlice({