Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giphy #1072

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Giphy #1072

wants to merge 1 commit into from

Conversation

gkasdorf
Copy link
Collaborator

@gkasdorf gkasdorf commented Nov 7, 2023

Add GIFs to comments and posts with Giphy.

  • Not using Giphy SDK. Phones home too much data to Giphy (Meta)
  • Not allowing client to interact with Giphy API directly (same reason)

How it works:

  1. User submits a Giphy query to Memmy API
  2. Memmy API submits the search query.
  3. Memmy API returns to the client the direct URL to each image and a proxied URL to each image.
  4. The client displays the results to the user through the proxied URL.
  5. User selects the image they want to add to the comment/post.
  6. The direct URL to the image is added to the comment/post.
  7. For one hour, Memmy will - on the user's device - replace the direct Giphy URL with a proxied URL.

This should prevent any peculiar tracking done by Meta. Maybe a bit over the top, but whatever.

Requests: https://github.com/Memmy-App/memmy-api/blob/main/app/Giphy/giphySearch.ts
Proxy: https://github.com/Memmy-App/memmy-api/blob/main/app/Controllers/Http/GiphyController.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant