feat: add Network URL non-ascii -> punycode warning

app/components/UI/NetworkVerificationInfo/NetworkVerificationInfo.tsx

@@ -295,7 +295,7 @@ const NetworkVerificationInfo = ({
   };
 
   const renderBannerNetworkUrlNonAsciiDetected = () => {
-    if (isValidASCIIURL(customRpcUrl)) { return null; }
+    if (!customRpcUrl || isValidASCIIURL(customRpcUrl)) { return null; }
     const punycodeUrl = toPunycodeURL(customRpcUrl);
 
     return (

app/util/url/index.ts

@@ -28,7 +28,10 @@ export function isBridgeUrl(url: string) {
 
 export const isValidASCIIURL = (urlString?: string) => {
   try {
-    return urlString?.includes(punycode.toASCII(new URL(urlString).host));
+    if (!urlString) { return false; }
+
+    const urlPunycodeString = punycode.toASCII(new URL(urlString).href);
+    return urlPunycodeString?.includes(urlString);
   } catch (exp: unknown) {
     console.error(exp);
     return false;
@@ -39,7 +42,7 @@ function removePathTrailingSlash(path: string) {
   return path.endsWith('/') ? path.slice(0, -1) : path;
 }
 
-/** 
+/**
  * Note: We use the punycode library here because the url library in react native doesn't support punycode encoding.
  * It is supported in node.js which allows tests to pass, but behavior in react-native does not match the
  * behavior in the tests. This differs from the toPunycodeURL util method in metamask-extension.

app/util/url/url.test.ts

@@ -66,9 +66,21 @@ describe('URL Check Functions', () => {
       expect(isValidASCIIURL('https://www.google.com')).toEqual(true);
     });
 
-    it('returns false for URL containing special character', () => {
+    it('returns true for URL with a path containing ASCII characters', () => {
+      expect(
+        isValidASCIIURL('https://infura.io/gnosis?x=xn--ifura-dig.io'),
+      ).toStrictEqual(true);
+    });
+
+    it('returns false for URL containing non-ASCII characters', () => {
       expect(isValidASCIIURL('https://iոfura.io/gnosis')).toStrictEqual(false);
     });
+
+    it('returns false for URL containing non-ASCII characters in its path', () => {
+      expect(
+        isValidASCIIURL('https://infura.io/gnosis?x=iոfura.io'),
+      ).toStrictEqual(false);
+    });
   });
 
   describe('toPunycodeURL', () => {