feat(fetchOEmbedData): Handle non-ok responses #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 179 182 +3
Branches 16 17 +1
=========================================
+ Hits 179 182 +3
Continue to review full report at Codecov.
|
MichaelDeBoey
changed the title
MichaelDeBoey
approved these changes
Mar 19, 2020
MichaelDeBoey
approved these changes
Mar 19, 2020
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Check OEmbed response status and throw if it's not
ok(200-299 status range)Why:
Because plugin currently doesn't handle case of non-ok response and have potential to throw very confusing errors that are hard to track down to root cause. Having explicit handling allow us to throw actionable errors (by pointing which links are problematic)
How:
Adding check for
response.okand throwing if it's falsy.The change also added need to do some changes to existing tests, where I changed mocks to use actual
Responseobject instead of fully mocked object (instead of addingokandstatusthere).Checklist:
Closes #99
Closes #103