Add b64d #2
Merged
Add b64d #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VixieTSQ
commented
Jul 3, 2022
|
|
||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | ||
|
|
||
| [profile.release] |
There was a problem hiding this comment.
Is this all really necessary? Especially abort on panic... really? space can't be that big of an issue
There was a problem hiding this comment.
agree, but we don't want a big size difference between go/Rust version
Go : 1.9M
Rust: 7.6M
we can disable remove abort line
| &mut file, | ||
| Config::new(charset, true) | ||
| ); | ||
| file.read_to_string(&mut decoded)?; // TODO: Doesn't like newlines |
There was a problem hiding this comment.
There is no super easy way to fix this because I am using the decoderreader thingy. I could just pull in the file whole for preprocessing before decoding it but that's quite sad.
If I really wanted to be stingy with memory, I could print out a byte at a time from the decoderreader.
|
hey @VixieTSQ , don't forget to add your info (email, username) to your git config in the next time thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.