refactor: refactor fuzzy search for users and conversations #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
YeungKC
commented
Jan 16, 2025
YeungKC
commented
- Added fuzzySearchUserItem and fuzzySearchConversationItem methods in the database layer for improved search functionality.
- Updated ConversationDao and UserDao to utilize the new search methods.
- Introduced SearchItem class to encapsulate search results.
- Refactored UI components to display search results using SearchItemWidget.
- Enhanced SQL queries in common.drift for better search performance and accuracy.
- Added fuzzySearchUserItem and fuzzySearchConversationItem methods in the database layer for improved search functionality. - Updated ConversationDao and UserDao to utilize the new search methods. - Introduced SearchItem class to encapsulate search results. - Refactored UI components to display search results using SearchItemWidget. - Enhanced SQL queries in common.drift for better search performance and accuracy.
- Moved search logic into dedicated _useSearchState and _useNavigationState hooks for better organization and readability. - Updated CommandPalettePage to utilize the new hooks, enhancing the separation of concerns. - Removed redundant code related to user and conversation search, streamlining the implementation. - Ensured that search results are displayed correctly using the updated state management approach.
…d palette navigation - Added 'fatal_warnings' option in build.yaml to enhance build error handling. - Updated command palette navigation logic to handle empty item lists gracefully, preventing potential runtime errors.
- Modified SQL queries in mixin_database.g.dart and common.drift to enhance the handling of the 'enableNameLike' condition. - Changed the condition from 'WHEN :enableNameLike = TRUE' to 'WHEN :enableNameLike != TRUE' for better clarity and functionality. - Ensured consistency in query logic across both files to improve search performance and accuracy.
- Updated fuzzy search methods in ConversationDao and UserDao to improve search accuracy by incorporating LIKE escape functionality. - Removed unnecessary parameters from fuzzy search queries to streamline logic. - Refactored SQL queries in mixin_database.g.dart and common.drift for better performance and clarity, ensuring consistent handling of search conditions. - Introduced LikeEscapeOperator and LikeEscapeExpression for improved LIKE query handling in the database layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.