Re-add Python 3.8 support

Moguri · Jul 28, 2023 · 3ea3dea · 3ea3dea · ekiefl · Jul 28, 2024
1 parent 014b163
commit 3ea3dea
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/pipeline.yaml b/.github/workflows/pipeline.yaml
@@ -6,7 +6,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
-        pyversion: ['3.9', '3.10']
+        pyversion: ['3.8', '3.9', '3.10']
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v3

diff --git a/gltf/_converter.py b/gltf/_converter.py
@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 import base64
 import collections
 import itertools
@@ -47,8 +49,8 @@ def get_extras(gltf_data):
 class CharInfo:
     character: p3d.Character
     nodepath: p3d.NodePath
-    jvtmap: dict[int, p3d.JointVertexTransform]
-    cvsmap: dict[tuple[int, str], p3d.CharacterVertexSlider]
+    jvtmap: 'dict[int, p3d.JointVertexTransform]'
+    cvsmap: 'dict[tuple[int, str], p3d.CharacterVertexSlider]'
 
     def __init__(self, name: str):
         self.character = p3d.Character(name)

diff --git a/gltf/_loader.py b/gltf/_loader.py
@@ -16,8 +16,8 @@ def load_model(file_path, gltf_settings=None):
 
 def _config_var_for_type(var_type):
     return {
-        str: p3d.ConfigVariableString,
-        bool: p3d.ConfigVariableBool,
+        'str': p3d.ConfigVariableString,
+        'bool': p3d.ConfigVariableBool,
     }.get(var_type, None)
 
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -24,7 +24,7 @@ dependencies = [
     "panda3d >= 1.10.8",
     "panda3d-simplepbr >= 0.6",
 ]
-requires-python = ">= 3.9"
+requires-python = ">= 3.8"
 
 [project.urls]
 homepage = "https://github.com/Moguri/panda3d-gltf"