Fix code scanning alert no. 58: Overly permissive file permissions #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
jordanpadams
requested review from
alexdunnjpl,
tloubrieu-jpl and
nutjob4life
as code owners
nutjob4life
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
This seems reasonable
I take it back—I thought this looked familiar, and it should be rejected for the same reason as the comment left there
nutjob4life
reviewed
Nov 18, 2024
There was a problem hiding this comment.
We should reject this as it's a duplicate of this PR and for the same reason.
|
Same as #448, closing code scan result as wontfix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/NASA-PDS/doi-service/security/code-scanning/58
To fix the problem, we need to change the file permissions to be more restrictive. Specifically, we should set the permissions so that only the owner can read and write the file, and no one else can access it. This can be achieved by changing the mode in the
os.chmodfunction from0o0664to0o0600.Suggested fixes powered by Copilot Autofix. Review carefully before merging.