Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timestamps in logs to enable matching with events server sides #217

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Add timestamps in logs to enable matching with events server sides #217

merged 1 commit into from
Dec 2, 2024

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Updated to latest log4j pattern.

⚙️ Test Data and/or Report

Log now looks like:

2024-11-14 10:24:50 [INFO ] (FileDownloader.java:download:79) 404 - Not Found
2024-11-14 10:24:50 [INFO ] (FileDownloader.java:download:82) Will retry in 5 seconds
2024-11-14 10:24:55 [INFO ] (FileDownloader.java:downloadOnce:106) Downloading https://pds.nasa.gov/pds4/mission/insight/v1/PDS4_INSIGHT_1A10_1830.JSON to /tmp/LDD-17278595985076089148.JSON

♻️ Related Issues

Partial #203

@al-niessner al-niessner requested a review from a team as a code owner November 14, 2024 18:26
@jordanpadams
Copy link
Member

@tloubrieu-jpl @alexdunnjpl @nutjob4life can we get a review on this? it is getting a bit stale.

alexdunnjpl
alexdunnjpl approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@alexdunnjpl alexdunnjpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly this is worth throwing in a constant somewhere if it's in use across the codebase?

But either way, approved

@nutjob4life
Copy link
Member

@alexdunnjpl beat me to it—but I'd also approve based on visual inspection

@jordanpadams jordanpadams merged commit 3e5d0c2 into main Dec 2, 2024
3 checks passed
@jordanpadams jordanpadams deleted the issue_203 branch December 2, 2024 18:20
@jordanpadams
Copy link
Member

thanks @alexdunnjpl @nutjob4life !

@jordanpadams
Copy link
Member

agreed on the global constant in registry common, but let's move this forward.

@jordanpadams jordanpadams mentioned this pull request Dec 3, 2024
Closed
@tloubrieu-jpl tloubrieu-jpl changed the title changes for common log4j Add timestamps in logs to enable matching with events server sides Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdunnjpl alexdunnjpl alexdunnjpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@al-niessner @jordanpadams @nutjob4life @alexdunnjpl