Skip to content
This repository has been archived by the owner on Dec 22, 2022. It is now read-only.

Full-text / keyword search #55

Closed
wants to merge 4 commits into from
Closed

Full-text / keyword search #55

wants to merge 4 commits into from

Conversation

tdddblog
Copy link
Contributor

@tdddblog tdddblog commented Aug 3, 2021

Summary
See https://github.com/NASA-PDS/pds-api/issues/99

Test instructions

  • Build and install latest pds-api-javalib (on "swaggerhub-pds_federated_api-keywords" branch if it is not merged into main)
  • Build latest registry-api-service
  • Build latest Harvest (on "keyword" branch if it is not merged into main)
  • Build latest Registry Manager (on "keyword" branch if it is not merged into main)
  • Delete old registry
  • Create new Registry
  • Harvest some data
  • Load harvested data into registry with Registry Manager
  • Search for some keywords from "title" or "description" fields.

@tdddblog tdddblog requested a review from tloubrieu-jpl August 3, 2021 15:28
@jordanpadams
Copy link
Member

@tdddblog can you take a look at why the build is breaking? also can you resolve the merge conflict?

@tdddblog
Copy link
Contributor Author

@jordanpadams The build is breaking because it needs latest changes from pds-api-javalib project.

@tdddblog
Copy link
Contributor Author

@jordanpadams It was too hard to resolve all the conflicts. I had to redo my changes and create new pull request #60
Can we expedite reviews of pull requests which require swagger spec changes to avoid complex merges.

@tdddblog tdddblog closed this Aug 11, 2021
@tdddblog tdddblog deleted the keyword branch August 11, 2021 00:29
@jordanpadams
Copy link
Member

@tdddblog per one of our previous sprints, if a PR is sitting out there for a while, let's bring it to our attention at a Sprint meeting and we can do a real-time demo and walk-through of the changes in the breakout so we can merge it. @tloubrieu-jpl and I are just overwhelmed with PRs, so we need some help knowing when things are higher priority versus others

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants