Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated es/registry arg #129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updated es/registry arg #129

wants to merge 1 commit into from

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Updated args and usage text as requested.

⚙️ Test Data and/or Report

create registry works no problem. Only test I did but it is just cut-n-paste everywhere.

♻️ Related Issues

Closes #125

@al-niessner al-niessner self-assigned this Jan 14, 2025
@al-niessner al-niessner requested a review from a team as a code owner January 14, 2025 22:39
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21.3% Duplication on New Code (required ≤ 3%)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@al-niessner
Copy link
Contributor Author

@jordanpadams @tloubrieu-jpl

If you want the code duplication reduced, then I need to rewrite all of registry-mgr. Give me a month and I will do it. Otherwise, cut-n-paste it is.

Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @al-niessner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update description for -es flag to make more sense to a novice user
2 participants