Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle new pagination with search-after parameter #65

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

tloubrieu-jpl
Copy link
Member

🗒️ Summary

Updates a notebook block to demonstrate the new pagination parameters and performance.

♻️ Related Issues

See ticket NASA-PDS/registry-api#352

@tloubrieu-jpl tloubrieu-jpl requested a review from a team as a code owner February 28, 2024 03:31
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, however it's using a mix of both pds.api_client and Python requests. Should it maybe use just 100% of one or the other?

@tloubrieu-jpl tloubrieu-jpl merged commit c368a95 into main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants