Update to match changes in Zonefilefmt in latest domain.
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I assume you're waiting for NLnetLabs/domain#463, but once that's merged this looks fine too.
tertsdiepraam
approved these changes
Dec 6, 2024
mozzieongit
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update follows the changes due to NLnetLabs/domain#446 being merged and the
initial-nsec3-generationbranch indomainhaving been synced withmain. This is needed because theinitial-nsec3-generationbranch is the branch ofdomaincurrently being used by thednstmainbranch.Note however another change will be needed when NLnetLabs/domain#463 is merged so it might be worth waiting for that then updating this PR again before merging this PR.