Retiring text_bytes_aware_shuffle to use shuffle directly
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
|
Thanks! Was wondering if you have any small-scale examples that could be added to |
VibhuJawa
reviewed
Oct 22, 2024
VibhuJawa
approved these changes
Oct 22, 2024
This was referenced Oct 9, 2024
praateekmahajan
changed the title
text_bytes_aware_shuffle to use shuffle directlytext_bytes_aware_shuffle to use shuffle directly
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
…raateek/fuzzy-shuffle-fix
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
sarahyurick
reviewed
Nov 8, 2024
nemo_curator/modules/fuzzy_dedup.py
Outdated
Comment on lines
1158
to
1160
| elif os.environ["SHUFFLE_APPROACH"] == "dask_vanilla": | ||
| self._logger.info("Using dask's vanilla shuffle") | ||
| output_df = subset_merged_df.shuffle(on=partition_on) |
There was a problem hiding this comment.
You could add shuffle_approach to FuzzyDuplicatesConfig if there's more than one of these that you think we should keep in the codebase. Up to you.
There was a problem hiding this comment.
@sarahyurick we won't be keeping all approaches, I just had them for my own benchmarking efforts. I'll update the PR with the results, and based on those we'll only be keeping the approach of dask_vanilla (once @ayushdg is able to confirm at scale too)
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
praateekmahajan
changed the title
text_bytes_aware_shuffle to use shuffle directlytext_bytes_aware_shuffle to use shuffle directly
praateekmahajan
added
gpuci
vinay-raman
pushed a commit
to vinay-raman/NeMo-Curator
that referenced
this pull request
Nov 26, 2024
…#316) Signed-off-by: Vinay Raman <[email protected]>
ruchaa-apte
pushed a commit
to ruchaa-apte/NeMo-Curator
that referenced
this pull request
Dec 13, 2024
…#316) Signed-off-by: Rucha Apte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that cudf supports large strings, we can use shuffle directly.
Resolves #240
Here is the performance improvement when compared existing older implementation (which ultimately called
rearrange_column_by_direct)Usage
# Add snippet demonstrating usageChecklist