Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bbonev/filter basis functions #57

Merged
merged 27 commits into from
Jan 14, 2025
Merged

Bbonev/filter basis functions #57

merged 27 commits into from
Jan 14, 2025

Conversation

bonevbs
Copy link
Collaborator

@bonevbs bonevbs commented Dec 10, 2024

Refactoring of code to support flexible choise of filter basis functions for spherical convolutions.

@bonevbs bonevbs requested a review from azrael417 December 10, 2024 16:57
Copy link
Collaborator

@azrael417 azrael417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just naming nitpicking.

torch_harmonics/convolution.py Outdated Show resolved Hide resolved
torch_harmonics/convolution.py Outdated Show resolved Hide resolved
torch_harmonics/filter_basis.py Outdated Show resolved Hide resolved
@bonevbs bonevbs force-pushed the bbonev/filter_basis_functions branch from 15c52e2 to 0ccb230 Compare December 12, 2024 14:35
@bonevbs bonevbs force-pushed the bbonev/filter_basis_functions branch from d4d23a0 to 7800662 Compare January 13, 2025 15:01
tests/test_convolution.py Show resolved Hide resolved
torch_harmonics/examples/models/_layers.py Show resolved Hide resolved
@bonevbs bonevbs merged commit 8680e02 into main Jan 14, 2025
1 check passed
@bonevbs bonevbs deleted the bbonev/filter_basis_functions branch January 14, 2025 16:09
@bonevbs bonevbs restored the bbonev/filter_basis_functions branch January 14, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants