Tkurth/torchification #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonevbs
reviewed
Jan 22, 2025
| ] | ||
| ) | ||
| def test_distributed_resampling( | ||
| self, nlat_in, nlon_in, nlat_out, nlon_out, batch_size, num_chan, grid_in, grid_out, mode, tol | ||
| self, nlat_in, nlon_in, nlat_out, nlon_out, batch_size, num_chan, grid_in, grid_out, mode, tol, verbose |
There was a problem hiding this comment.
does the verbose option exist in all tests now? Would be good to have it for consistency
bonevbs
reviewed
Jan 22, 2025
bonevbs
reviewed
Jan 22, 2025
bonevbs
reviewed
Jan 22, 2025
bonevbs
reviewed
Jan 22, 2025
| @@ -34,6 +34,7 @@ | |||
| import torch.nn as nn | |||
| import torch_harmonics as harmonics | |||
|
|
|||
| import math | |||
| import numpy as np | |||
There was a problem hiding this comment.
is it possible to remove the numpy import here? Ideally we should get rid of numpy for everything that gets imported with torch-harmonics
bonevbs
reviewed
Jan 22, 2025
bonevbs
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Looks already very good to me. Most comments are minor things. I would suggest adding some form of tests for the cache and the modified routines for the grid/quadrature precomputations to make sure they work as intended.
Please also update pyprojerct.toml and Changelog.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following features: