Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cuhpx for reordering on gpu #8

Merged
merged 3 commits into from
Aug 24, 2024
Merged

use cuhpx for reordering on gpu #8

merged 3 commits into from
Aug 24, 2024

Conversation

nbren12
Copy link
Collaborator

@nbren12 nbren12 commented Aug 21, 2024

No description provided.

@nbren12 nbren12 self-assigned this Aug 21, 2024
@nbren12 nbren12 requested a review from akshaysubr August 21, 2024 05:07
Copy link
Collaborator

@akshaysubr akshaysubr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just added a few comments on code structure and one comment on additional functionality that might be good to add.

earth2grid/healpix.py Show resolved Hide resolved
earth2grid/healpix.py Show resolved Hide resolved
earth2grid/healpix.py Show resolved Hide resolved
@nbren12
Copy link
Collaborator Author

nbren12 commented Aug 22, 2024

Thanks Akshay. please note that all the to_xy_cuda methods are following a double dispatch pattern and not intended to be public.

@nbren12
Copy link
Collaborator Author

nbren12 commented Aug 22, 2024

I chose OO-style double dispatch to avoid writing a long reorder function with many if-statements.

@akshaysubr
Copy link
Collaborator

Ah, sorry, I missed the XY.to_xy_cuda method which already has the functionality that I incorrectly thought was missing. Looks good to merge now!

@nbren12 nbren12 merged commit 5b9b294 into main Aug 24, 2024
1 of 2 checks passed
@nbren12 nbren12 deleted the cuhpx-reordering branch August 24, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants