Update from PR comments

NYPL · Jan 21, 2025 · 6b6f1c9 · 6b6f1c9
1 parent 32ec96d
commit 6b6f1c9
Show file tree

Hide file tree

Showing 3 changed files with 517 additions and 3 deletions.
diff --git a/lib/sierra-models/bib.js b/lib/sierra-models/bib.js
@@ -37,7 +37,7 @@ class SierraBib extends SierraBase {
 
     // Having 910 $a contain 'RLOTF' is also a solid indicator introduced in OTF
     // record creation Oct 2021 https://github.com/NYPL/recap-hold-request-consumer/pull/33
-    const hasOtf910 = this._varField910().includes('RLOTF')
+    const hasOtf910 = this._varField910a().includes('RLOTF')
 
     return hasOtfLocation || hasOtf910
   }
@@ -70,7 +70,7 @@ class SierraBib extends SierraBase {
     }
 
     // Check 910 $a for RL or BL:
-    const researchBranchFlags = this._varField910()
+    const researchBranchFlags = this._varField910a()
     if (researchBranchFlags.length !== 0) {
       const isResearch = researchBranchFlags.includes('RL') || researchBranchFlags.includes('RLOTF')
       return { isResearch, rationale: `910 $a is ${researchBranchFlags}` }
@@ -108,7 +108,7 @@ class SierraBib extends SierraBase {
    *  These values typically are RL for Research bibs, BL for Branch bibs, or
    *  RLOTF for OTF (Research) bibs
    */
-  _varField910 () {
+  _varField910a () {
     const varField = this.varField('910', ['a'])
     return Array.isArray(varField) ? varField.map(field => field.value) : []
   }