Merge pull request #102 from NYPL/SCC-4344/add-recordTypeId

Scc 4344/add record type
NYPL · Dec 3, 2024 · c4affcd · c4affcd
2 parents 23607d8 + fa795ef
commit c4affcd
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/lib/elastic-search/index-schema.js b/lib/elastic-search/index-schema.js
@@ -332,7 +332,7 @@ exports.schema = () => ({
   publicDomain: propertyTemplates.boolean,
   publisherLiteral: propertyTemplates.fulltextWithRawFolded,
   publicationStatement: propertyTemplates.exactStringNotIndexed,
-  recordType: propertyTemplates.exactString,
+  recordTypeId: propertyTemplates.exactString,
   serialPublicationDates: propertyTemplates.exactStringNotIndexed,
   seriesStatement: propertyTemplates.fulltextWithRawFolded,
   shelfMark: {

diff --git a/lib/es-models/bib.js b/lib/es-models/bib.js
@@ -614,8 +614,8 @@ class EsBib extends EsBase {
   }
 
   recordTypeId () {
-    const recordType = this.bib.ldr()?.recType
-    if (recordType) return recordType
+    const recordTypeId = this.bib.ldr()?.recType
+    if (recordTypeId) return recordTypeId
     else return null
   }
 

diff --git a/scripts/mapping-check.js b/scripts/mapping-check.js
@@ -33,7 +33,7 @@ kmsSetCredentials(awsCreds)
 exports.getMapping = async (index) => {
   const client = await esClient.client()
   const resp = await client.indices.getMapping({ index })
-  return resp.body[index].mappings.resource.properties
+  return resp.body[index].mappings.properties
 }
 
 /**

diff --git a/test/unit/scripts-mapping-check.test.js b/test/unit/scripts-mapping-check.test.js
@@ -40,9 +40,8 @@ describe('scripts/mapping-check', () => {
       return {
         body: {
           [index]: {
-            mappings: {
-              resource: { properties: fakeMappings }
-            }
+            mappings: { properties: fakeMappings }
+
           }
         }
       }