SCC-4347 - Add scripts/update-property-by-csv script #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add update-property-by-csv script for updating a single property in many ES documents based on a CSV of any length. For example, this can be used to update the `recordTypeId` for every bib in the index if you have a CSV containing columns id, nyplSource, recordTypeId. https://newyorkpubliclibrary.atlassian.net/browse/SCC-4347
| * - errored {object[]} - Array of objects representing non-404 errors, one per document | ||
| * - missing {object[]} - Array of objects representing 404 errors, one per document | ||
| **/ | ||
| const parseErroredDocuments = (bulkResponse, operations) => { |
There was a problem hiding this comment.
what is operations here?
There was a problem hiding this comment.
Added documentation. It's the array of objects we send to the ES _bulk api that alternately identify the document to update and the property to update. E.g.:
[
{ update: { _index: 'index-name', _id: 'b1' } },
{ doc: { myProp: 'new prop value 1' } },
{ update: { _index: 'index-name', _id: 'b2' } },
{ doc: { myProp: 'new prop value 2' } },
...
]
Sending a stream of those in one call to the ES _bulk api is very fast compared with issuing POSTs to each document id
charmingduchess
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add update-property-by-csv script for updating a single property in many ES documents based on a CSV of any length. For example, this can be used to update the
recordTypeIdfor every bib in the index if you have a CSV containing columns id, nyplSource, recordTypeId.https://newyorkpubliclibrary.atlassian.net/browse/SCC-4347