Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCC-4455] Support multiple 910|a fields #105

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

yossariano
Copy link
Contributor

See https://newyorkpubliclibrary.atlassian.net/browse/SCC-4455 - this change adds support for checking multiple 910|a values for whether a bib/item is meant for research, instead of just the first value in the field.

Testing

  • Updated tests to include a fixture with both BL and RL in the 910|a field.

@charmingduchess
Copy link
Contributor

I'm also not seeing any prior unit tests for this method. I think it would be a good idea to add some edge case coverage for isOtfRecord or maybe updating these suppression tests.

@yossariano
Copy link
Contributor Author

I'm also not seeing any prior unit tests for this method. I think it would be a good idea to add some edge case coverage for isOtfRecord or maybe updating these suppression tests.

It is implicitly tested with this test (it failed with multiple 910|a fields previously):

  prefilter
    filteredSierraBibsForBibs
      1) should keep Research bibs

but I'm adding more explicit testing now!

@yossariano yossariano merged commit 20e3e55 into main Jan 22, 2025
3 checks passed
@yossariano yossariano deleted the SCC-4455-multiple-910a branch January 22, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants