[Feat] Model registry endpoints #209
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,6 +9,14 @@ class NodeServer(BaseModel): | |||
| port: int | |||
| node_id: str | |||
|
|
|||
| class ModelConfig(BaseModel): | |||
There was a problem hiding this comment.
We already have a schema called LLMConfig
| name: str | ||
| model_id: str = Field(..., description="Unique ID for the model, e.g., 'mistralai/Mistral-7B-Instruct-v0.1'") | ||
| node_id: str | ||
| communication_protocol: str = Field("http", description="Communication protocol (http, ws, grpc)") |
There was a problem hiding this comment.
the schema should look similar to Module. communication protocol should not be related to model.
| @@ -134,6 +134,101 @@ async def tool_create_endpoint(tool_input: ToolDeployment) -> ToolDeployment: | |||
| """ | |||
| return await self.tool_create(tool_input) | |||
|
|
|||
| @router.post("/model/register", response_model=ModelRegistrationResponse) | |||
There was a problem hiding this comment.
you don't need to create fastapi endpoints for registering things in the hub. the api is built into surrealdb. check how we do it for registering agent, tool modules etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue
Ps.- initial exploration, not yet complete