Password fixes for SamsungTV - fixes #15 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for tracking this down. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samsung TV doesn't show the very last folder while navigating the password folders – that's the 4th folder when using password length of 4 – because apparently Samsung TV doesn't like
childcountof zero and would show the folder as empty when this happens.The second issue is that the password for Samsung TV – when entered correctly – never get stored, because Samsung TV only sends
BrowseMetadataflag while browsing the password folders.This pull request fixes both issues and I've got password protection working properly for my Samsung 7 Series TV, along with other devices.