Implement password update when .password file changes (fixes #2) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeavenVolkoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #21.
As I stated in the previous PR, there were some inconsistent behavior that could happen if a
.passwordfile were to be modified while the minidlna server was running. I concluded that the best way to fix this was to implement a solution for #2. Also, I fixed some bugs that remained in the previous PR.The current logic propagates any modification to a
.passwordfile to all files and directories under its influence, and also respects boundaries between upper and sub directories with different.passwordfiles. As far as I could test it seems to be working fine. However, more tests are very welcomed, specially in systems that usekqueueinstead ofinotifyas, although I implemented the logic for triggering the password update inmonitor_kqueue.c, I don't have a system compatible with it, so I couldn't test it.