Added people assignment to projects and some fixes #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realised I forgot the case when project is not found in the request to add a connection. Will attend to it tomorrow. |
|
Is this up on stage? |
aanil
reviewed
Jan 17, 2025
| <div> | ||
| <input class="form-control" id="formModifyUserName" placeholder="" disabled type="text"> | ||
| </div> | ||
| <label for="modifyName" class="fw-bold">Name</label> | ||
| <input class="form-control" id="formModifyName" placeholder="Name..." type="text"> |
There was a problem hiding this comment.
Name comes from the GoogleUser currently and we probably shouldn't allow it to be modified from genstat. People can update their own google profiles to get names right.
There was a problem hiding this comment.
Ah, true. I'll have a look. We could probably use that instead.
There was a problem hiding this comment.
True, I didn't consider this, but starting to think about it, would it work to fetch other users´names?
aanil
reviewed
Jan 17, 2025
aanil
approved these changes
Jan 20, 2025
alneberg
merged commit 56fa0cf
into
NationalGenomicsInfrastructure:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes together with:
https://github.com/NationalGenomicsInfrastructure/StatusDB_views/pull/190