Revert "Updates Dispatch Conversation URLs to reflect complete worksp…

…ace URL (#3449)" (#3522) This reverts commit f4c720f. Co-authored-by: Marc Vilanova <[email protected]>
Netflix · Jun 22, 2023 · 8eee40a · 8eee40a
1 parent 7a92c4c
commit 8eee40a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 20 deletions.
diff --git a/src/dispatch/plugins/dispatch_slack/enums.py b/src/dispatch/plugins/dispatch_slack/enums.py
@@ -2,10 +2,8 @@
 
 
 class SlackAPIGetEndpoints(DispatchEnum):
-    chat_permalink = "chat.getPermalink"
     conversations_history = "conversations.history"
     conversations_info = "conversations.info"
-    team_info = "team.info"
     users_conversations = "users.conversations"
     users_info = "users.info"
     users_lookup_by_email = "users.lookupByEmail"

diff --git a/src/dispatch/plugins/dispatch_slack/service.py b/src/dispatch/plugins/dispatch_slack/service.py
@@ -86,12 +86,6 @@ def list_conversation_messages(client: WebClient, conversation_id: str, **kwargs
     )
 
 
-@functools.lru_cache()
-def get_domain(client: WebClient) -> str:
-    """Gets the team's Slack domain."""
-    return make_call(client, SlackAPIGetEndpoints.team_info)["team"]["domain"]
-
-
 @functools.lru_cache()
 def get_user_info_by_id(client: WebClient, user_id: str) -> dict:
     """Gets profile information about a user by id."""
@@ -194,7 +188,7 @@ def create_conversation(client: WebClient, name: str, is_private: bool = False)
     return {
         "id": response["id"],
         "name": response["name"],
-        "weblink": f"https://{get_domain(client)}.slack.com/app_redirect?channel={response['id']}",
+        "weblink": f"https://slack.com/app_redirect?channel={response['id']}",
     }
 
 
@@ -269,15 +263,6 @@ def add_users_to_conversation(
                 pass
 
 
-def get_message_permalink(client: WebClient, conversation_id: str, ts: str) -> str:
-    return make_call(
-        client,
-        SlackAPIGetEndpoints.chat_permalink,
-        channel=conversation_id,
-        message_ts=ts,
-    )
-
-
 def send_message(
     client: WebClient,
     conversation_id: str,
@@ -302,7 +287,7 @@ def send_message(
     return {
         "id": response["channel"],
         "timestamp": response["ts"],
-        "weblink": get_message_permalink(client, response["channel"], response["ts"]),
+        "weblink": f"https://slack.com/app_redirect?channel={response['id']}",  # TODO should we fetch the permalink?
     }
 
 
@@ -326,7 +311,7 @@ def update_message(
     return {
         "id": response["channel"],
         "timestamp": response["ts"],
-        "weblink": get_message_permalink(client, response["channel"], response["ts"]),
+        "weblink": f"https://slack.com/app_redirect?channel={response['id']}",  # TODO should we fetch the permalink?
     }