Don't install cythonize dependencies unless cythonizing #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy is not building in my environment, but I should not need to have it if all I want to build is the default libvmaf target. Additionally: Instead of using the mtime of the .venv directory as a marker for whether meson and ninja were successfully installed, use their wrapper scripts from .venv/bin. The $(VENV) target uses set -e and escaped newlines to run all commands in a single shell invocation. Unless these commands are modifying the shell's environment, this is redundant and mimics the way make already works when you put a single command on each line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy is not building in my environment, but I should not need to have it if all I want to build is the default libvmaf target.
Additionally:
Instead of using the mtime of the .venv directory as a marker for whether meson and ninja were successfully installed, use their wrapper scripts from .venv/bin.
The $(VENV) target uses set -e and escaped newlines to run all commands in a single shell invocation. Unless these commands are modifying the shell's environment, this is redundant and mimics the way make already works when you put a single command on each line.