Fix contract class unmarshall for modern cairo compilers #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added contract casm compiled by scarn 2.7.0 compiler * added tests to unmarshall contract class from new casm json format
…compilers * Added bytecode_segment_lengths field to CasmClass, allowing for backward compatibility * Added NestedUInts type to handle deserialisation of CasmClass * Added test to check that ClassHash now respects bytecode_segment_lengths and calculates correct value
… of Declare transation * Simplify nested string
thiagodeev
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Thanks for your help, @baitcode!
I left some comments, mostly about testing
Added argent 0.4.0 contract. Fixed review comments
|
@thiagodeev Fixed! Added argent account contract v0.4.0 to hash tests. |
thiagodeev
requested changes
Feb 7, 2025
|
@thiagodeev Thank you very much for the review. I've fixed all the comments. |
thiagodeev
requested changes
Feb 11, 2025
contracts/contracts_test.go
Outdated
|
|
||
| expectedEntryPoint := testCase.ExpectedCasmClass.EntryPointByType | ||
|
|
||
| // External |
There was a problem hiding this comment.
We can just use:
assert.Equal(t, casmClass.EntryPointByType.External, expectedEntryPoint.External)
assert.Equal(t, casmClass.EntryPointByType.Constructor, expectedEntryPoint.Constructor)
assert.Equal(t, casmClass.EntryPointByType.L1Handler, expectedEntryPoint.L1Handler)
There was a problem hiding this comment.
I can't remember why exactly I decided to compare everything explicitly so will have to fix. Will leave a comment next time.
hash/hash.go
Outdated
| return felt.Zero.Add( | ||
| zero := &felt.Felt{} | ||
|
|
||
| return zero.Add( |
There was a problem hiding this comment.
We don't need a new var, we can just pass new(felt.Felt) directly
* added test for new sierra hash * simplified EntryPoint comparisons in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #655
Added workaround for abi data that is not string, but json object.
Fix ClassHash calculation for casm compiled classes for modern cairo compilers
Here is the snippet for hash values generation with starknet.py:
https://gist.github.com/baitcode/5adec0f74121d0ae3a09aaf573ff8665