Update route if acquired time changes #441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Records last time route was acquired so we can determine if change needs to be pushed out to network. Allows for route expiry to be updated by RouterAdvertisement for example.
rsmarples
reviewed
Jan 24, 2025
src/route.c
Outdated
| if (ort->rt_mtu == nrt->rt_mtu) | ||
| /* If it has not been renewed by RA, and MTU is unchanged, skip */ | ||
| if (ort->rt_updated.tv_sec == nrt->rt_updated.tv_sec && | ||
| ort->rt_mtu == nrt->rt_mtu) |
There was a problem hiding this comment.
Can we not just test if rt_expires is different?
There was a problem hiding this comment.
The code originally checked if mtu was identical, we still want it to skip the push if mtu is unchanged, right?
There was a problem hiding this comment.
I want to skip the push if the route is unchanged. So compare mtu and expires - if the same we skip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a route gets an update (say from an RA), consider it changed so new expiry gets pushed out to system.