WIP: Implement arbitrary field sequences #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neumann-A
reviewed
Jun 22, 2022
Comment on lines
22
to
50
| #include "Constant.hpp" | ||
| #include "Field.hpp" | ||
| #include "Lissajous.hpp" | ||
| #include "ModulatedSinc.hpp" | ||
| #include "Rectangular.hpp" | ||
| #include "Sinc.hpp" | ||
| #include "Sinusoidal.hpp" | ||
| #include "Triangular.hpp" | ||
| #include "Zero.hpp" | ||
|
|
||
|
|
||
| #ifndef INC_SEQUENCEFIELDS_H | ||
| #define INC_SEQUENCEFIELDS_H | ||
| template <typename prec> | ||
| class ZeroField; | ||
| template <typename prec> | ||
| class ConstantField; | ||
| template <typename prec> | ||
| class LissajousField; | ||
| template <typename prec> | ||
| class RectangularField; | ||
| template <typename prec> | ||
| class SinusoidalField; | ||
| template <typename prec> | ||
| class TriangularField; | ||
| template <typename prec> | ||
| class SincField; | ||
| template <typename prec> | ||
| class ModulatedSincField; |
There was a problem hiding this comment.
Why do you need the forward definitions and the includes ?
Neumann-A
reviewed
Jun 22, 2022
Comment on lines
33
to
34
| #ifndef INC_SEQUENCEFIELDS_H | ||
| #define INC_SEQUENCEFIELDS_H |
Neumann-A
reviewed
Jun 22, 2022
Comment on lines
107
to
110
| #ifndef INC_SEQUENCEFieldSelector_H | ||
| #define INC_SEQUENCEFieldSelector_H | ||
| ///--------------------------------------------------------------------------------------------------- | ||
| #pragma once |
Neumann-A
reviewed
Jun 22, 2022
Comment on lines
104
to
105
| #endif // INC_FieldList_H | ||
| // end of Fields\FieldList.h |
Neumann-A
reviewed
Jun 22, 2022
| @@ -543,7 +545,7 @@ case Value: \ | |||
| protected: | |||
| SimulationManager() = default; | |||
| public: | |||
| STOPHYSIM_EXPORT SimulationManager(const Parameters &SimManSet) | |||
| STOPHYSIM_EXPORT SimulationManager(const Settings::SimulationManagerSettings<prec> &SimManSet) | |||
Neumann-A
reviewed
Jun 22, 2022
Comment on lines
35
to
37
| Application SimManager{ std::move(input.getAppParams()) }; | ||
| Settings::SimulationManagerSettings<PREC> test{input.getAppParams()}; | ||
| Application SimManager{ test }; | ||
|
|
Neumann-A
reviewed
Jun 22, 2022
| Properties::Fields::Lissajous<PREC> fieldprops{ {},Pos,ampl,freq, phases }; | ||
| Properties::Fields::Sequence<PREC> fieldprops2{{},3,fields }; |
There was a problem hiding this comment.
Changes in this file necessary ? Or was this just testing?
Neumann-A
reviewed
Jun 22, 2022
Neumann-A
reviewed
Jun 22, 2022
Neumann-A
reviewed
Jun 22, 2022
| @@ -111,5 +113,6 @@ namespace SettingsFileGen | |||
| SYSMATFILEGENMAKRO(field_enum_property_mapping<IField::Field_Rectangular>::type) | |||
| SYSMATFILEGENMAKRO(field_enum_property_mapping<IField::Field_Sinc>::type) | |||
| SYSMATFILEGENMAKRO(field_enum_property_mapping<IField::Field_Modsinc>::type) | |||
| //SYSMATFILEGENMAKRO(field_enum_property_mapping<IField::Field_Sequence>::type) | |||
Neumann-A
reviewed
Jun 22, 2022
| @@ -11,6 +11,7 @@ set(H_FILES_Fields Fields/FieldList.h | |||
| Fields/RectangularField.h | |||
| Fields/SincField.h | |||
| Fields/ModulatedSincField.h | |||
| Fields/SequenceField.h | |||
Co-authored-by: Alexander Neumann <[email protected]>
Co-authored-by: Alexander Neumann <[email protected]>
|
@TobiasKlemme: Könntest du bitte ein Issue öffnen mit dem Fehler von dem du mir berichtet hattest und die Configs in das Issue anhängen? Ich hatte lokal versucht den Fehler zu reproduzieren, konnte aber keinen Fehler finden. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented sequence field