Update NixRawIO to strictly follow RawIO data structure #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the NixRawIO this implies - loading of a single block only (as in nix there is no reason to assume consistent channel/stream structure across blocks) - introducing checks for channel & id consistencies across segments - introducing `autogenerate_*` keyword argument for ignoring non-rawio compatible channel names and unit ids in nix files - add static `get_block_count` method to permit scanning of nix file for number of blocks - the `block_index` argument is now already required at IO initialization
JuliaSprenger
force-pushed
the
enh/nixiofr_blocks
branch
from
86e1faf to
e3296df
Compare
- adjust parameters for loading additional tests files - fix code layout
|
@Kleinjohann Can you test this implementation with some of your nix files? |
|
With https://gin.g-node.org/NeuralEnsemble/ephy_testing_data/pulls/100 merged, tests are passing now. |
Hi! Thanks for the work! |
|
Todos:
|
|
@JuliaSprenger do you want to implement your "todo" item, or shall we merge now and fix that later? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the IO to read only data that follow the RawIO restrictions. For loading old data
autogenerate_*keywords were introduced to permit loading data, but ignoring inconsistent channel / unit names. Since there is no structural relation between blocks in nix, it is only possible to load a single block at time. The substructure of that block has to follow the rawio constraints.This PR is requires test files added in https://gin.g-node.org/NeuralEnsemble/ephy_testing_data/pulls/100 .