Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved docker / container support #812

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jusito
Copy link

@jusito jusito commented Jan 9, 2021

Issue #705

  • allow to disable auto update -> added update_rs(..., $mode = 'default') possible to set from environment variable for none/major/minor/patch, if variable isn't set same behavior as before
    • fix explicit version checks
  • create dbconfig if not exists in php
    • add migration from old other/dbconfig.php -> config/db.php
  • worker.php status checks for
    • process running
    • ts3 connection successful
    • last update successful
  • all changes tested
  1. Iam not experienced in PHP so a review before removing WIP is mandatory in my opinion.
  2. Is there an prefered testing method?
  3. Do you prefer a two step pr? E.g. first for changes needed in preparation but without Dockerfile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant