Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build blueprint-compiler from source #741

Merged
merged 7 commits into from
Nov 17, 2023
Merged

build blueprint-compiler from source #741

merged 7 commits into from
Nov 17, 2023

Conversation

soumyaDghosh
Copy link
Member

Changes in this PR

  1. Building blueprint-compiler from source
  2. removing the patch

@fsobolev do you think that the patch worth maintaining?

@soumyaDghosh soumyaDghosh self-assigned this Nov 17, 2023
@nlogozzo nlogozzo requested review from nlogozzo and removed request for nlogozzo November 17, 2023 11:18
@nlogozzo
Copy link
Member

do you think that the patch worth maintaining?

What was the purpose of the patch in the first place? Wasn't it because the icon didn't show without it?

@nlogozzo
Copy link
Member

The build is still failing :/

@soumyaDghosh soumyaDghosh marked this pull request as draft November 17, 2023 13:37
@soumyaDghosh
Copy link
Member Author

What was the purpose of the patch in the first place? Wasn't it because the icon didn't show without it?

The patch is there to show the symbolic icon in the gnome activities icon.

@nlogozzo
Copy link
Member

What was the purpose of the patch in the first place? Wasn't it because the icon didn't show without it?

The patch is there to show the symbolic icon in the gnome activities icon.

So why would we get rid of that...

@soumyaDghosh
Copy link
Member Author

What was the purpose of the patch in the first place? Wasn't it because the icon didn't show without it?

The patch is there to show the symbolic icon in the gnome activities icon.

So why would we get rid of that...

This much change just for a symbolic icon! It's not like the app doesn't show any icon, it just shows the black and white version of the app's original icon

@soumyaDghosh soumyaDghosh marked this pull request as ready for review November 17, 2023 14:32
@nlogozzo
Copy link
Member

This much change just for a symbolic icon!

I don't mind maintaining it to show the correct icon. It's not like the desktop file changes often where we need to fix the patch. Just when we move things around, but I update the patch.

Please restore it back, I'll maintain it dw

nlogozzo
nlogozzo requested changes Nov 17, 2023
View reviewed changes
snap/denaro.patch Outdated Show resolved Hide resolved
.github/workflows/snap.yml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
@nlogozzo nlogozzo merged commit 88a0ec4 into main Nov 17, 2023
4 checks passed
@nlogozzo nlogozzo deleted the snap branch November 17, 2023 14:47
@nlogozzo
Copy link
Member

Could you do the same PR for Tagger please?

@soumyaDghosh
Copy link
Member Author

Sure.. just a moment, working on snapcraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlogozzo nlogozzo nlogozzo approved these changes

@fsobolev fsobolev Awaiting requested review from fsobolev

Assignees

@soumyaDghosh soumyaDghosh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soumyaDghosh @nlogozzo