-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print to stderr when there is an exception #763
Conversation
Now this is just to make debugging for #762 a tiny bit easier. Will go through and complete the PR by tuesday :) |
Might be best to Ctrl+Shift+F for |
Alright! Also probably better to use Console.Error. I forgot that earlier |
Console.WriteLine is probably fine...stdput and stderr point to the same terminal unless the programmer usually redirects it to a separate file which we don't really in this case... |
It is actually two different streams but most terminals won't differentiate by default. Its standard thing for most programs to print use the correct output stream. Also users can manually redirect errors as well to a file or whatever. Since Denaro isn't a command line app, it probably doesn't really matter. Since I'm gonna have to go through everything anyway, might as well fix the few logs already being printed out. |
I'll complete this in the afternoon. Have been a bit busy |
GNOME: Account - Fix catch block formatting Shared: Account - Log error when ExportToCSV fails Shared: Account - Add error logs
0c9853b
to
f544010
Compare
GNOME: MainWindowController - Fix formatting
f544010
to
5ceca95
Compare
Added Console.Error.WriteLine to most catch blocks that made sense to me. I ignored the ones that executed sql queries and such. |
Idk why rider keeps adding these in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR should add logs in missed places.