-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xmlto: use docbook-xml-ns package XSD files (offline mode) #301631
Conversation
Since c1ae842 ("xmlto: use docbook-xml-ns package XSD files (offline mode)"), the dbus-daemon man page is garbled: Before:
After:
Any ideas? |
c1ae842 changed `xmlto` to use docbook stylesheets from the nix store instead of downloading them. However, it used the namespaced version despite the URI being for non-namespaced version, causing problems with generated man pages as reported in #301631 (comment), #299081 (comment), and #339078. This patch fixes the issue by pointing to `nons` version of the stylesheets.
Fixed in 6d24a9c. I believe we previously relied on In other toolchains where DocBook is only one of many supported formats and not always used, having it looked up through XML catalog at runtime might be desirable to avoid the hefty 22 MiB build time closure increase in cases that do not need |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.