Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realmd: init at 0.17.1 #302083

Merged
merged 1 commit into from
Apr 10, 2024
Merged

realmd: init at 0.17.1 #302083

merged 1 commit into from
Apr 10, 2024

Conversation

anthonyroussel
Copy link
Member

@anthonyroussel anthonyroussel commented Apr 6, 2024

Description of changes

See #302069

This is a continuation of the work carried out by:

realmd being complicated, I suggest splitting the work: the package, then the NixOS module.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@anthonyroussel
Copy link
Member Author

anthonyroussel commented Apr 6, 2024

@ofborg build realmd

@anthonyroussel anthonyroussel force-pushed the add-realmd-package branch 3 times, most recently from a2c136e to b9b4688 Compare April 6, 2024 12:25
@Sigmanificient
Copy link
Member

Result of nixpkgs-review pr 302083 run on x86_64-linux 1

1 package built:
  • realmd

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 6, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 6, 2024
@marsam marsam merged commit f9cee33 into NixOS:master Apr 10, 2024
34 checks passed
@anthonyroussel anthonyroussel deleted the add-realmd-package branch April 10, 2024 13:55
@anthonyroussel anthonyroussel mentioned this pull request Apr 10, 2024
5 tasks
@bb010g bb010g mentioned this pull request Oct 11, 2024
11 tasks
@ghost ghost mentioned this pull request Jan 22, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants