Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typespec: init at 0.64.0 #359016

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

PauKaifler
Copy link
Contributor

@PauKaifler PauKaifler commented Nov 25, 2024

This PR adds typespec, a compiler with included language server for defining API shapes for REST, OpenAPI, gRPC and others.
We have been using this derivation at work for some time and it worked well.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 25, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 25, 2024
Copy link
Contributor

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Nixpkgs ❤️ Just a couple of things:

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/by-name/ty/typespec/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ty/typespec/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ty/typespec/package.nix Outdated Show resolved Hide resolved
@PauKaifler
Copy link
Contributor Author

Thanks for your quick review! I implemented your suggestions.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 25, 2024
Copy link
Contributor

@steeleduncan steeleduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the root repository has github releases, I believe you could add an update script

https://wiki.nixos.org/wiki/Nixpkgs/Update_Scripts

That would simplify updates as they'll be generated automatically by a bot

pkgs/by-name/ty/typespec/package.nix Outdated Show resolved Hide resolved
@PauKaifler
Copy link
Contributor Author

PauKaifler commented Nov 26, 2024

As the root repository has github releases, I believe you could add an update script

Good idea, thanks. I now added one.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2024
@steeleduncan
Copy link
Contributor

@PauKaifler By the way, it has been a while, and this risks getting lost in the sea of nixpkgs PRs. My suggestion would be to find someone who has merged a similar package into nixpkgs recently, and request a review from them

@steeleduncan steeleduncan self-requested a review December 20, 2024 23:15
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 21, 2024
@PauKaifler
Copy link
Contributor Author

PauKaifler commented Jan 7, 2025

I implemented the recommendations given by @wolfgangwalther and rebased to master.

Since this PR has been opened, a new TypeSpec version has been released (0.63.0).
Should I create a new PR with the version and hashes changed, or is it preferable to directly update this one?

@wolfgangwalther
Copy link
Contributor

Should I create a new PR with the version and hashes changed, or is it preferable to directly update this one?

Please update this one.

@PauKaifler PauKaifler changed the title typespec: init at 0.62.0 typespec: init at 0.63.0 Jan 7, 2025
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 7, 2025
@PauKaifler PauKaifler changed the title typespec: init at 0.63.0 typespec: init at 0.64.0 Jan 16, 2025
@PauKaifler
Copy link
Contributor Author

PauKaifler commented Jan 16, 2025

Thanks for the heads-up, @gepbird. I applied the change.

Also, I updated TypeSpec to 0.64.0 because there has been a new release yesterday.

@wegank wegank added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Jan 16, 2025
@FliegendeWurst FliegendeWurst merged commit 9a29738 into NixOS:master Jan 16, 2025
31 of 34 checks passed
@PauKaifler PauKaifler deleted the typespec-0.62.0 branch January 16, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants