Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.mirage-crypto-rng-eio: init at 1.1.0 #362377

Merged
merged 1 commit into from
Dec 10, 2024
Merged

ocamlPackages.mirage-crypto-rng-eio: init at 1.1.0 #362377

merged 1 commit into from
Dec 10, 2024

Conversation

vog
Copy link
Contributor

@vog vog commented Dec 6, 2024 •
edited
Loading

Add the missing sub package mirage-crypto-rng-eio to the already existing variants mirage-crypto-rng-lwt, mirage-crypto-rng-async and mirage-crypto-rng-mirage.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from ulrikstrid December 6, 2024 11:24
@vog vog requested a review from sternenseemann December 6, 2024 11:25
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 6, 2024
@vog vog force-pushed the mirage-crypto-rng-eio-init branch from cdca6d1 to 4917b19 Compare December 6, 2024 11:32
@vog vog force-pushed the mirage-crypto-rng-eio-init branch from 4917b19 to f59f2da Compare December 6, 2024 11:36
@vog
Copy link
Contributor Author

vog commented Dec 10, 2024 •
edited
Loading

@sternenseemann As the current maintainer of the ocamlPackages.mirage-crypto-* packages, do you have any objections to adding this missing piece?

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 10, 2024
@ulrikstrid ulrikstrid merged commit 037038b into NixOS:master Dec 10, 2024
33 checks passed
@vog vog added the backport release-24.11 Backport PR automatically label Dec 10, 2024
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 10, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 10, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

@ulrikstrid ulrikstrid ulrikstrid approved these changes

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vog @ulrikstrid @vbgl @wegank