Add warning for configuration file copy in flake systems #363021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
13 tasks
NixOSInfra
added
the
12. first-time contribution
transgirllucy
changed the title
|
This should target master. |
kjeremy
reviewed
Dec 9, 2024
| If enabled, this option copies the NixOS | ||
| configuration file (usually {file} = /etc/nixos/configuration.nix) and symlinks it from the resulting system {{file} to /run/current-system/configuration.nix} | ||
| Note: that only this single file is copied, even if it import others. | ||
| Warning: This feature cannot be used when the system is configured as a flake. |
There was a problem hiding this comment.
I think this should be by a flake since a system is not a flake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds a warning to the documentation regarding the use of the configuration file copy feature. It clarifies that this feature cannot be used when the system is configured as a flake.
This change aims to prevent confusion.
Changes
Added a warning in the documentation that the configuration file copy feature cannot be used with flake-based systems.
Motivation:
The intention of this change is to prevent confusion among users who may attempt to use the configuration file copy feature while operating within a flake-based environment. By providing clear guidance, we aim to enhance the user experience and ensure that users are aware of the limitations associated with flakes.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.