Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.chex: temporarily disable tests on python 3.13 #369258

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

GaetanLepage
Copy link
Contributor

Things done

=========================== short test summary info ============================
FAILED chex/_src/dataclass_test.py::DataclassesTest::test_tree_flatten_with_keys - ValueError: The truth value of an array with more than one element is ambig...
FAILED chex/_src/variants_test.py::FailedTestsTest::test_useful_errors - AttributeError: module 'unittest' has no attribute 'makeSuite'
FAILED chex/_src/variants_test.py::FailedTestsTest::test_useful_failures - AttributeError: module 'unittest' has no attribute 'makeSuite'
FAILED chex/_src/variants_test.py::OneFailedVariantTest::test_useful_failure - AttributeError: module 'unittest' has no attribute 'makeSuite'
FAILED chex/_src/variants_test.py::WrongBaseClassTest::test_wrong_base_class - AttributeError: module 'unittest' has no attribute 'makeSuite'
FAILED chex/_src/variants_test.py::BaseClassesTest::test_inheritance_parameterized - AttributeError: module 'unittest' has no attribute 'makeSuite'
FAILED chex/_src/variants_test.py::BaseClassesTest::test_inheritance_variants - AttributeError: module 'unittest' has no attribute 'makeSuite'
FAILED chex/_src/variants_test.py::BaseClassesTest::test_inheritance_variants_and_parameterized - AttributeError: module 'unittest' has no attribute 'makeSuite'
FAILED chex/_src/variants_test.py::VariantsTestCaseWithParameterizedTest::test_should_pass - AttributeError: module 'unittest' has no attribute 'makeSuite'
FAILED chex/_src/variants_test.py::UnusedVariantTest::test_unused_variant - AttributeError: module 'unittest' has no attribute 'makeSuite'
FAILED chex/_src/variants_test.py::UnknownVariantArgumentsTest::test_unknown_argument - AttributeError: module 'unittest' has no attribute 'makeSuite'
FAILED chex/_src/variants_test.py::VariantTypesTest::test_var_type_fetch - AttributeError: module 'unittest' has no attribute 'makeSuite'
FAILED chex/_src/variants_test.py::CountVariantsTest::test_counters - AttributeError: module 'unittest' has no attribute 'makeSuite'
============ 13 failed, 554 passed, 85 skipped in 84.20s (0:01:24) =============

google-deepmind/chex#371
google-deepmind/chex#372

cc @ndl

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew
Copy link
Contributor

lucasew commented Dec 30, 2024

This may have a solution:

@GaetanLepage
Copy link
Contributor Author

This may have a solution:

* Issue in another project: [unittest.makeSuite() is deprecated in Python 3.11 and will be removed in Python 3.13 maxcountryman/flask-seasurf#107](https://github.com/maxcountryman/flask-seasurf/issues/107)

* Their solution: https://github.com/maxcountryman/flask-seasurf/pull/119/files

Thanks for the pointers. I think that upstream is already aware. Let's just fix it on their end and disable tests in the meantime.

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GaetanLepage GaetanLepage merged commit 64388c3 into NixOS:master Dec 30, 2024
23 of 24 checks passed
@GaetanLepage GaetanLepage deleted the chex branch December 30, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants