Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/realmd: init #372318

Merged
merged 1 commit into from
Jan 17, 2025
Merged

nixos/realmd: init #372318

merged 1 commit into from
Jan 17, 2025

Conversation

liberodark
Copy link
Contributor

@liberodark liberodark commented Jan 9, 2025 •
edited
Loading

Hi,

The goal of this PR is to add realmd service available in nixos.
This don't fix totally : #303144

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 9, 2025
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Jan 9, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 9, 2025
@ofborg ofborg bot removed the ofborg-internal-error Ofborg encountered an error label Jan 9, 2025
@liberodark liberodark force-pushed the realmd branch 2 times, most recently from 6c12689 to fc229cd Compare January 9, 2025 11:02
GaetanLepage
GaetanLepage reviewed Jan 16, 2025
View reviewed changes
nixos/modules/services/misc/realmd.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/realmd.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/realmd.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/realmd.nix Outdated Show resolved Hide resolved
GaetanLepage
GaetanLepage approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
However, I would prefer if a more NixOS-module-focused maintainer could double-check it.

@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jan 17, 2025
SuperSandro2000
SuperSandro2000 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could add some more hardening though

@liberodark
Copy link
Contributor Author

Hi,

Also if this PR can be backport to 24.11 because this fix a issue for service missing.

Best Regards

@SuperSandro2000 SuperSandro2000 added the backport release-24.11 Backport PR automatically label Jan 17, 2025
@SuperSandro2000 SuperSandro2000 merged commit 06172a7 into NixOS:master Jan 17, 2025
7 of 9 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 17, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 17, 2025
Merged
1 task
@ghost ghost mentioned this pull request Jan 22, 2025
Closed
4 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/is-active-directory-support-a-thing-in-nixos/30058/20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liberodark @nixos-discourse @SuperSandro2000 @GaetanLepage @h7x4