nixos/systemd-tmpfiles: fix ordering of systemd-tmpfiles-setup-sysroot #374076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change a service failure would occur when this tmpfiles service did not finish fast enough and receive a SIGTERM from systemd. Additionally, `initrd-nixos-activation` is already ordered with `After=initrd-switch-root.target`.
github-actions
bot
added
6.topic: nixos
|
@ofborg test systemd-initrd-simple |
github-actions
bot
added
10.rebuild-darwin: 0
nikstur
approved these changes
Jan 15, 2025
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change a service failure would occur when this tmpfiles service did not finish fast enough and receive a SIGTERM from systemd. Additionally,
initrd-nixos-activationis already ordered withAfter=initrd-switch-root.target.On master the failure can easily be reproduced by
sleeping a few seconds inExecStart[Pre]of the tmpfiles service, otherwise this seems to occur very rarely and took a while to discover.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.