Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pingvin-share: 1.8.0 -> 1.8.1 #374111

Merged
merged 1 commit into from
Jan 17, 2025
Merged

pingvin-share: 1.8.0 -> 1.8.1 #374111

merged 1 commit into from
Jan 17, 2025

Conversation

weriomat
Copy link
Contributor

Changelog

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@weriomat
Copy link
Contributor Author

I would love to see this pr or this one backported due to this cve. I don't know how to backport (and I don't have the permission to set labels). Thank you in advance.

@getchoo
Copy link
Member

getchoo commented Jan 15, 2025

Thanks for catching that. I've opened #374145 to backport everything

getchoo
getchoo approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but diff LGTM

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 15, 2025
@getchoo getchoo added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 15, 2025
@FliegendeWurst FliegendeWurst merged commit 97bfe72 into NixOS:master Jan 17, 2025
27 of 29 checks passed
dustypomerleau pushed a commit to dustypomerleau/nixpkgs that referenced this pull request Jan 20, 2025
@FliegendeWurst @dustypomerleau
pingvin-share: 1.8.0 -> 1.8.1 (NixOS#374111)
5bb0a16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RatCornu RatCornu RatCornu approved these changes

@getchoo getchoo getchoo approved these changes

Assignees
No one assigned
Labels
12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weriomat @getchoo @RatCornu @FliegendeWurst